Skip to content

Create clean UI flow enticing the user to plug in the power supply before proceeding. #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jan 13, 2022
Merged

Create clean UI flow enticing the user to plug in the power supply before proceeding. #19

merged 17 commits into from
Jan 13, 2022

Conversation

aentinger
Copy link
Contributor

@aentinger aentinger commented Jan 12, 2022 •
edited
Loading

Note: For some reason the power-detection does not work when USB-C power cable is applied past software startup, however this needs to be fixed at a later point in time.

@aentinger
Set-up power before running either custom or default menu.
bd05a99
@aentinger
Enable larger font with size 32px.
248243d
@aentinger
Use LVGL instead of direct GFX calls for writing power message to TFT…
263d9db 
… display.
@aentinger
Delete out-dated/out-commented code.
bdc99ca
@aentinger
Start display thread earlier. This allows to skip calling the display…
466ff98 
… task handler manually within 'splashScren'.
@aentinger
mbed is the only platform we run this library on, hence we can drop t…
1a3af7c 
…he include guards.
@aentinger
Since the Arduino GIF is white, we may just as well configure for whi…
2db0bde 
…te background from the start.
@aentinger
Prolonge showing of Arduino GIF.
c52923d
@aentinger
Replace 'while(1)' with 'for(;;)' which more expressively says 'infin…
cec317a 
…ite loop here'.
@aentinger
Show empty battery symbol in order to entice user to connect power.
6d1044c
@aentinger aentinger added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jan 12, 2022
@aentinger aentinger self-assigned this Jan 12, 2022
@github-actions
Copy link

Memory usage change @ 6d1044c

Board flash % RAM for global variables %
arduino:mbed_nano:nanorp2040connect 0 - 0 0.0 - 0.0 🔺 +24 - +224 +0.01 - +0.08
Click for full report table
Board examples/Braccio__Template
flash		 % examples/Braccio__Template
RAM for global variables		 % examples/Braccio_factory_setID_interactive
flash		 % examples/Braccio_factory_setID_interactive
RAM for global variables		 % examples/LCD_Custom_Menu
flash		 % examples/LCD_Custom_Menu
RAM for global variables		 % examples/LCD_Menu_Joystick
flash		 % examples/LCD_Menu_Joystick
RAM for global variables		 % examples/LCD_Motors
flash		 % examples/LCD_Motors
RAM for global variables		 % examples/LearnByDoing
flash		 % examples/LearnByDoing
RAM for global variables		 % examples/New_APIs
flash		 % examples/New_APIs
RAM for global variables		 % examples/Tools/Check_Inputs
flash		 % examples/Tools/Check_Inputs
RAM for global variables		 % examples/Tools/Test_Motor_Angular_Control
flash		 % examples/Tools/Test_Motor_Angular_Control
RAM for global variables		 % examples/Tools/Test_Motor_Communication
flash		 % examples/Tools/Test_Motor_Communication
RAM for global variables		 %
arduino:mbed_nano:nanorp2040connect 0 0.0 24 0.01 0 0.0 224 0.08 0 0.0 24 0.01 0 0.0 24 0.01 0 0.0 24 0.01 0 0.0 24 0.01 0 0.0 24 0.01 0 0.0 24 0.01 0 0.0 24 0.01 0 0.0 24 0.01
Click for full report CSV 
Board,examples/Braccio__Template<br>flash,%,examples/Braccio__Template<br>RAM for global variables,%,examples/Braccio_factory_setID_interactive<br>flash,%,examples/Braccio_factory_setID_interactive<br>RAM for global variables,%,examples/LCD_Custom_Menu<br>flash,%,examples/LCD_Custom_Menu<br>RAM for global variables,%,examples/LCD_Menu_Joystick<br>flash,%,examples/LCD_Menu_Joystick<br>RAM for global variables,%,examples/LCD_Motors<br>flash,%,examples/LCD_Motors<br>RAM for global variables,%,examples/LearnByDoing<br>flash,%,examples/LearnByDoing<br>RAM for global variables,%,examples/New_APIs<br>flash,%,examples/New_APIs<br>RAM for global variables,%,examples/Tools/Check_Inputs<br>flash,%,examples/Tools/Check_Inputs<br>RAM for global variables,%,examples/Tools/Test_Motor_Angular_Control<br>flash,%,examples/Tools/Test_Motor_Angular_Control<br>RAM for global variables,%,examples/Tools/Test_Motor_Communication<br>flash,%,examples/Tools/Test_Motor_Communication<br>RAM for global variables,%
arduino:mbed_nano:nanorp2040connect,0,0.0,24,0.01,0,0.0,224,0.08,0,0.0,24,0.01,0,0.0,24,0.01,0,0.0,24,0.01,0,0.0,24,0.01,0,0.0,24,0.01,0,0.0,24,0.01,0,0.0,24,0.01,0,0.0,24,0.01

@github-actions
Copy link

Memory usage change @ 1daccfd

Board flash % RAM for global variables %
arduino:mbed_nano:nanorp2040connect 0 - 0 0.0 - 0.0 🔺 +16 - +216 +0.01 - +0.08
Click for full report table
Board examples/Braccio__Template
flash		 % examples/Braccio__Template
RAM for global variables		 % examples/Braccio_factory_setID_interactive
flash		 % examples/Braccio_factory_setID_interactive
RAM for global variables		 % examples/LCD_Custom_Menu
flash		 % examples/LCD_Custom_Menu
RAM for global variables		 % examples/LCD_Menu_Joystick
flash		 % examples/LCD_Menu_Joystick
RAM for global variables		 % examples/LCD_Motors
flash		 % examples/LCD_Motors
RAM for global variables		 % examples/LearnByDoing
flash		 % examples/LearnByDoing
RAM for global variables		 % examples/New_APIs
flash		 % examples/New_APIs
RAM for global variables		 % examples/Tools/Check_Inputs
flash		 % examples/Tools/Check_Inputs
RAM for global variables		 % examples/Tools/Test_Motor_Angular_Control
flash		 % examples/Tools/Test_Motor_Angular_Control
RAM for global variables		 % examples/Tools/Test_Motor_Communication
flash		 % examples/Tools/Test_Motor_Communication
RAM for global variables		 %
arduino:mbed_nano:nanorp2040connect 0 0.0 16 0.01 0 0.0 216 0.08 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01
Click for full report CSV 
Board,examples/Braccio__Template<br>flash,%,examples/Braccio__Template<br>RAM for global variables,%,examples/Braccio_factory_setID_interactive<br>flash,%,examples/Braccio_factory_setID_interactive<br>RAM for global variables,%,examples/LCD_Custom_Menu<br>flash,%,examples/LCD_Custom_Menu<br>RAM for global variables,%,examples/LCD_Menu_Joystick<br>flash,%,examples/LCD_Menu_Joystick<br>RAM for global variables,%,examples/LCD_Motors<br>flash,%,examples/LCD_Motors<br>RAM for global variables,%,examples/LearnByDoing<br>flash,%,examples/LearnByDoing<br>RAM for global variables,%,examples/New_APIs<br>flash,%,examples/New_APIs<br>RAM for global variables,%,examples/Tools/Check_Inputs<br>flash,%,examples/Tools/Check_Inputs<br>RAM for global variables,%,examples/Tools/Test_Motor_Angular_Control<br>flash,%,examples/Tools/Test_Motor_Angular_Control<br>RAM for global variables,%,examples/Tools/Test_Motor_Communication<br>flash,%,examples/Tools/Test_Motor_Communication<br>RAM for global variables,%
arduino:mbed_nano:nanorp2040connect,0,0.0,16,0.01,0,0.0,216,0.08,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01

@aentinger aentinger marked this pull request as ready for review January 13, 2022 08:09
@aentinger aentinger merged commit b3a1a21 into master Jan 13, 2022
@aentinger aentinger deleted the fix-stabilise-power-before-menu branch January 13, 2022 08:09
@github-actions
Copy link

Memory usage change @ 90d6a15

Board flash % RAM for global variables %
arduino:mbed_nano:nanorp2040connect 🔺 +3828 - +3828 +0.02 - +0.02 🔺 +56 - +256 +0.02 - +0.09
Click for full report table
Board examples/Braccio__Template
flash		 % examples/Braccio__Template
RAM for global variables		 % examples/Braccio_factory_setID_interactive
flash		 % examples/Braccio_factory_setID_interactive
RAM for global variables		 % examples/LCD_Custom_Menu
flash		 % examples/LCD_Custom_Menu
RAM for global variables		 % examples/LCD_Menu_Joystick
flash		 % examples/LCD_Menu_Joystick
RAM for global variables		 % examples/LCD_Motors
flash		 % examples/LCD_Motors
RAM for global variables		 % examples/LearnByDoing
flash		 % examples/LearnByDoing
RAM for global variables		 % examples/New_APIs
flash		 % examples/New_APIs
RAM for global variables		 % examples/Tools/Check_Inputs
flash		 % examples/Tools/Check_Inputs
RAM for global variables		 % examples/Tools/Test_Motor_Angular_Control
flash		 % examples/Tools/Test_Motor_Angular_Control
RAM for global variables		 % examples/Tools/Test_Motor_Communication
flash		 % examples/Tools/Test_Motor_Communication
RAM for global variables		 %
arduino:mbed_nano:nanorp2040connect 3828 0.02 56 0.02 3828 0.02 256 0.09 3828 0.02 56 0.02 3828 0.02 56 0.02 3828 0.02 56 0.02 3828 0.02 56 0.02 3828 0.02 56 0.02 3828 0.02 56 0.02 3828 0.02 56 0.02 3828 0.02 56 0.02
Click for full report CSV 
Board,examples/Braccio__Template<br>flash,%,examples/Braccio__Template<br>RAM for global variables,%,examples/Braccio_factory_setID_interactive<br>flash,%,examples/Braccio_factory_setID_interactive<br>RAM for global variables,%,examples/LCD_Custom_Menu<br>flash,%,examples/LCD_Custom_Menu<br>RAM for global variables,%,examples/LCD_Menu_Joystick<br>flash,%,examples/LCD_Menu_Joystick<br>RAM for global variables,%,examples/LCD_Motors<br>flash,%,examples/LCD_Motors<br>RAM for global variables,%,examples/LearnByDoing<br>flash,%,examples/LearnByDoing<br>RAM for global variables,%,examples/New_APIs<br>flash,%,examples/New_APIs<br>RAM for global variables,%,examples/Tools/Check_Inputs<br>flash,%,examples/Tools/Check_Inputs<br>RAM for global variables,%,examples/Tools/Test_Motor_Angular_Control<br>flash,%,examples/Tools/Test_Motor_Angular_Control<br>RAM for global variables,%,examples/Tools/Test_Motor_Communication<br>flash,%,examples/Tools/Test_Motor_Communication<br>RAM for global variables,%
arduino:mbed_nano:nanorp2040connect,3828,0.02,56,0.02,3828,0.02,256,0.09,3828,0.02,56,0.02,3828,0.02,56,0.02,3828,0.02,56,0.02,3828,0.02,56,0.02,3828,0.02,56,0.02,3828,0.02,56,0.02,3828,0.02,56,0.02,3828,0.02,56,0.02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aentinger aentinger

Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aentinger